Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: anrok <> credit_notes model changes #2558

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Feat: anrok <> credit_notes model changes #2558

merged 8 commits into from
Sep 11, 2024

Conversation

annvelents
Copy link
Contributor

We need to adjust credit_note and credit_note::applied_tax to reflect the changes in processing taxes:

  • applied_tax might not belong to a stored in lago tax, so tax_id becomes optional,
  • during reporting we might receive some errors, so credit_note can have many :error_details

@annvelents annvelents marked this pull request as ready for review September 10, 2024 13:43
@annvelents annvelents merged commit d2f5348 into main Sep 11, 2024
6 checks passed
@annvelents annvelents deleted the feat-anrok-cn-model-changes branch September 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincent-pochet vincent-pochet vincent-pochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annvelents @vincent-pochet